Closed RubenKelevra closed 2 years ago
lidel
commented
2 years ago Electron version is specified in package.json:
https://github.com/ipfs/ipfs-desktop/blob/3bc3a8a29e16473a11786fa0b9f1d42365f436af/package.json#L56
npm ci will download it into node_modules/electron.
My (biased) opinion is that investing time in anything non-standard around Electron is not worth your time, disk space is less valuable than the time wasted on chasing bugs introduced by custom build.
RubenKelevra
commented
2 years ago @lidel so electron itself will be fetched into the built environment. But it won't fetch the dependencies.
If I install electron as a system package it will fetch a lot of dependencies. Are they necessary for the built environment's electron as well?
Name : electron
Version : 16.0.8-1
Description : Build cross platform desktop apps with web technologies
Architecture : x86_64
URL : https://electronjs.org/
Licenses : MIT custom
Groups : None
Provides : electron16
Depends On : c-ares ffmpeg gtk3 libevent libxslt minizip nss re2 snappy
Optional Deps : kde-cli-tools: file deletion support (kioclient5)
libappindicator-gtk3: StatusNotifierItem support
pipewire: WebRTC desktop sharing under Wayland
trash-cli: file deletion support (trash-put)
xdg-utils: open URLs with desktop's default (xdg-email, xdg-open)
I'm maintaining the AUR package for Arch Linux.
Going through the dependencies I notice that the previous maintainer added a lot of dependencies of Electron instead of specifying Electron itself.
I was wondering if the current build script would notice a locally installed Electron and not download it again in the
prepare()step.And I was wondering how the electron version is properly chosen/specified.
The Electron package (currently version 16) on Arch does provide the following:
While for example, electron15 does provide the following:
So as soon as electron 17 comes out, I need a way to specify that version 16 should be used, by specifying a path for that.
Build script for reference