ipfs / ipfs-desktop

An unobtrusive and user-friendly desktop application for IPFS on Windows, Mac and Linux.
https://docs.ipfs.tech/install/ipfs-desktop/
MIT License
5.99k stars 865 forks source link

Slow test file: test/e2e/launch.e2e.test.js (42s) #2116

Open SgtPooki opened 2 years ago

SgtPooki commented 2 years ago

We should optimize and speed up these tests.

npm run test:e2e

> ipfs-desktop@0.20.5 test:e2e
> xvfb-maybe cross-env NODE_ENV=test playwright test test/e2e/launch.e2e.test.js

Running 10 tests using 1 worker

  ✓  test/e2e/launch.e2e.test.js:66:3 › Application launch › creates a repository on startup (5s)
  ✓  test/e2e/launch.e2e.test.js:80:3 › Application launch › starts fine when node is already running (4s)
  ✓  test/e2e/launch.e2e.test.js:88:3 › Application launch › applies config migration (MDNS.enabled) (4s)
  ✓  test/e2e/launch.e2e.test.js:109:3 › Application launch › applies config migration (Web UI CORS 1) (4s)
  ✓  test/e2e/launch.e2e.test.js:131:3 › Application launch › applies config migration (Web UI CORS 2) (4s)
  ✓  test/e2e/launch.e2e.test.js:152:3 › Application launch › applies config migration (Web UI CORS 3) (4s)
  ✓  test/e2e/launch.e2e.test.js:173:3 › Application launch › applies config migration (ConnMgr) (4s)
  ✓  test/e2e/launch.e2e.test.js:194:3 › Application launch › starts with repository with "IPFS_PATH/api" file and no daemon running (6s)
  ✓  test/e2e/launch.e2e.test.js:210:3 › Application launch › starts with multiple api addresses (4s)
  ✓  test/e2e/launch.e2e.test.js:222:3 › Application launch › starts with multiple gateway addresses (4s)

  Slow test file: test/e2e/launch.e2e.test.js (42s)
  Consider splitting slow test files to speed up parallel execution

  10 passed (42s)
SgtPooki commented 2 years ago

they're using unique repos, but i'm not sure if they're using unique HOME for these tests. We should check if we can parallelize these - @lidel

hacdias commented 2 years ago

We do use unique HOMEs for these tests. Another consideration to have is that the IPFS daemon must always start on different ports.

Gulu888 commented 2 years ago

Help wanted