search

ipfs / ipfs-desktop

An unobtrusive and user-friendly desktop application for IPFS on Windows, Mac and Linux.
https://docs.ipfs.tech/install/ipfs-desktop/
MIT License
5.93k stars 855 forks source link

fix: apple notarization of ipfs-desktop binary #2623

Closed SgtPooki closed 11 months ago

SgtPooki commented 11 months ago

cc https://github.com/ipfs/ipfs-desktop/issues/1753

apple notarization is currently failing (see failing CI for https://github.com/ipfs/ipfs-desktop/pull/2621)

we have a PL apple developer account (as mentioned here), but I don't believe we're currently using that one for ipfs-desktop.

Either way, I don't have access to the one-password account that we're currently using for notarization.

I reached out to Andy to try and get us unblocked.

SgtPooki commented 11 months ago

Seems like a new contract needed signed (by Wayne). It was signed and the CI seems to be succeeding now: https://github.com/ipfs/ipfs-desktop/actions/runs/6151308066/job/16727491264

Also, the failed warning indicates we will start having problems in a few months without some updates:

Warning: altool has been deprecated for notarization and starting in late 2023 will no longer be supported by the Apple notary service. You should start using notarytool to notarize your software.

From https://github.com/electron/notarize/issues/137#issuecomment-1578500573, it seems like updating the call to notarize with:

{
    //...
    tool: 'notarytool',
    teamId: '7Y229E2YRL' // team ID confirmed with Wayne and seems to be output here: https://github.com/ipfs/ipfs-desktop/actions/runs/6151308066/job/16727491264#step:12:67
}

should be all we need.