search

ipfs / ipfs-desktop

An unobtrusive and user-friendly desktop application for IPFS on Windows, Mac and Linux.
https://docs.ipfs.tech/install/ipfs-desktop/
MIT License
5.94k stars 857 forks source link

bug: auto-update errors #2631

Closed SgtPooki closed 10 months ago

SgtPooki commented 12 months ago

Some users have reported errors with auto-updating ipfs-desktop.

This issue is intended to track them all and work to resolution.

related countly errors (permissioned URL)

related issues

BigLep commented 12 months ago

I attached my logs: biglep-2023-09-18-ipfsDesktopLogs.zip

SgtPooki commented 12 months ago

I didn't see anything obvious in steve's logs.

I just downloaded an old version of IPFS-desktop https://github.com/ipfs/ipfs-desktop/releases/tag/v0.26.1, blocked access to ipfs.io, ran ipfs-desktop v0.26.1, and then selected "check for updates" and it did not update successfully. I am investigating this in addition to https://github.com/ipfs/ipfs-desktop/issues/2632

SgtPooki commented 12 months ago

going to download v0.28.0 manually and then try manual-update.

SgtPooki commented 12 months ago

v0.28.0 manual update failed. I saw the new app open and then close, and then v0.28.0 re-opened. nothing useful in logs.

SgtPooki commented 12 months ago

v0.29.0 manual update also failed. no useful log output other than 2023-09-19T18:48:10.578Z info: [beforeQuitCleanup] stopIpfs had finished with status: 5

SgtPooki commented 12 months ago

manual immediate update also failed for ipfs-desktopv0.30.0, so, i decided to try to "install later" and see if that worked. It did for ipfs-desktopv0.30.0. here are the steps:

  1. click "check for updates" in the systray
  2. click "install later" on the popup
  3. make sure combined.log includes a line saying 2023-09-19T18:53:00.202Z info: [updater] update to 0.30.2 downloaded
  4. quit ipfs-desktop
  5. run ipfs-desktop from applications after a few minutes (let electron-updater do it's install stuff during shutdown, ala https://github.com/ipfs/ipfs-desktop/blob/b097be6f06ab1fa325681c67cb9fb67d83e84a2e/src/auto-updater/index.js#L24).

@BigLep can you try this on your version to see if that fixes things?

SgtPooki commented 12 months ago

I was also able to successfully update v0.26.1 to v0.30.2 by choosing to "install later". seems like we have a bug with using quitAndInstall(), which may also impact auto-update outside of application restarts.

BigLep commented 12 months ago

@SgtPooki : earlier this morning I quit IPFS Desktop. I then just relaunched it, and during the relaunch it appeared to be updating and then I confirmed that I had indeed been updated. I have attached my combined.log.