search

ipfs / ipfs-desktop

An unobtrusive and user-friendly desktop application for IPFS on Windows, Mac and Linux.
https://docs.ipfs.tech/install/ipfs-desktop/
MIT License
5.93k stars 855 forks source link

IPNS CID should have association with cid in files tab #2663

Open meandavejustice opened 10 months ago

meandavejustice commented 10 months ago

Describe the bug When viewing files in the files tab, I am always able to "Publish to IPNS" even if I have already published this file. It seems to me, the UI should know and reflect that. Also we should display/have the ability to copy the IPNS CID from this view

To Reproduce Steps to reproduce the behavior:

  1. Import file
  2. Click on '....'
  3. Click "Publish to IPNS", choose key etc...
  4. Navigate away from view
  5. Repeat steps 2 and 3 and see that you get the same view.

Expected behavior

Screenshots If applicable, add screenshots to help explain your problem.

image image

Additional context Add any other context about the problem here.

welcome[bot] commented 10 months ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

Finally, remember to use https://discuss.ipfs.io if you just need general support.

SgtPooki commented 10 months ago

@meandavejustice thanks for submitting this feature request! I think this will need addressed in ipfs-webui, but I will get to triaging this soon.

SamarthBagga commented 8 months ago

Hi @SgtPooki, I'm eager to kick off work on this—unless someone else is already tackling it?

SgtPooki commented 8 months ago

Hi @SgtPooki, I'm eager to kick off work on this—unless someone else is already tackling it?

No one is currently working on this to my knowledge!

Please go for it! Let me know if you need any assistance

SamarthBagga commented 8 months ago

Hi @SgtPooki, Can you confirm if the feature request involves adding a UI section to indicate whether a file has been published to IPFS? If so, could you please specify the exact location in the UI where the information about the IPFS CID for the already published file should be displayed?

SgtPooki commented 8 months ago

Hi @SgtPooki, Can you confirm if the feature request involves adding a UI section to indicate whether a file has been published to IPFS?

If so, could you please specify the exact location in the UI where the information about the IPFS CID for the already published file should be displayed?

@SamarthBagga we are currently on holiday break until the new year. I’d have to dive into this a bit further to propose UI specifics.

Maybe @meandavejustice could chime in here, otherwise I will be able to get back to you in early Jan.

SamarthBagga commented 8 months ago

okay sure!

SgtPooki commented 7 months ago

@SamarthBagga sorry for taking so long to get back to you.

I would imagine we want something similar to the Pinning modal, where we list the pinning providers, with a checkbox next to them if they're already pinned with that provider.

Screenshot is below:

image
SgtPooki commented 7 months ago

we should also add a new column to the files table to show which IPNS key the CID is published to, similar to "Pin Status"

image
lidel commented 7 months ago

Sounds sensible. We could even simplify "Pin Status" to "Status" and have megaphone icon there next to pin to indicate it was published with one of IPNS keys, and clicking on it opens the IPNS details modal you suggested.