ipfs / ipfs-desktop

An unobtrusive and user-friendly desktop application for IPFS on Windows, Mac and Linux.
https://docs.ipfs.tech/install/ipfs-desktop/
MIT License
5.85k stars 849 forks source link

Restore macOS builds to use ARM-based `macos-latest` #2813

Closed lidel closed 2 weeks ago

lidel commented 1 month ago

This is the actual fix that needs to happen after workaround from https://github.com/ipfs/ipfs-desktop/pull/2811 was merged.

The way we build for macOS right now is to do Intel build, and leverage intel emulation on ARM. This works, we have single build that works on both ARM and Intel, because intel Kubo binary is also used.

Unfortunately it is not future-proof, as ARM is the bew default.

Regressions like https://github.com/ipfs/ipfs-desktop/issues/2809 will happen. Right now we are not able to build on macos-latest (14) because it is ARM-based, and there is no Intel version anymore.

Next steps

We need to rework the way our macOS build works.

There is some prior work and research done in https://github.com/ipfs/ipfs-desktop/pull/1856 and in https://github.com/ipfs/ipfs-desktop/issues/2681.

Initial thoughts: