ipfs / ipfs-docs

📚IPFS documentation platform
https://docs.ipfs.tech
299 stars 411 forks source link

Update docs to reflect Relay V1 (server) removal from go-ipfs #1146

Closed lidel closed 1 year ago

lidel commented 2 years ago

We need to update all places that mention EnableRelayHop – Relay V1 server was removed from go-ipfs 0.11 and now requires running a separate binary.

See details in:

The most important is to update "browsers connectivity" tutorial by @TheDiscordian:

  1. https://blog.ipfs.io/2021-06-10-guide-to-ipfs-connectivity-in-browsers/
  2. https://docs.ipfs.io/how-to/create-simple-chat-app/

(We seem to already document v1 and v2 in https://docs.ipfs.io/concepts/nodes/#types)

lidel commented 2 years ago

@TheDiscordian as you are the original author of the tutorial, would you have time to update it? My next 2-3 weeks are pretty packed, and I won't be able to do this any time soon.

TheDiscordian commented 2 years ago

@lidel I'd love to, I plan to have this updated by Friday. (Edit: Though could be as late as next Wednesday)

lidel commented 2 years ago

@TheDiscordian this is probably a bad question to ask at 2AM, but since all peers use the same webrtc signaling server, and they can post their own multiaddr to the same pubsub channel, why do we need the Python script for advertising on pubsub on their behalf? I feel i am missing something.

TheDiscordian commented 2 years ago

@lidel I missed this until now, the reason for the pubsub is for the relay connections (IE: Cannot punch for WebRTC). Node A connects to Relay, Relay advertises Node A, Node B connects to Relay, Relay advertises Node B, Node A now has a path to Node B, connecting them together via Relay.

ElPaisano commented 1 year ago

@BigLep @lidel can you help Johnny and I determine if this is still relevant?

From https://docs.ipfs.tech/concepts/nodes/#relay, it looks like we still mention relay v1

ElPaisano commented 1 year ago

Removing the P1 label, as the team doesn't seem to be pressing this issue. Will keep in backlog until I hear back.

ElPaisano commented 1 year ago

Since https://docs.ipfs.io/how-to/create-simple-chat-app/ has been removed as part of the js-ipfs cleanup, this is no longer relevant. Closing.