ipfs / ipfs-docs

📚IPFS documentation platform
https://docs.ipfs.tech
299 stars 409 forks source link

fix: :wastebasket: Deprecation notice for js-ipfs #1628

Closed whizzzkid closed 1 year ago

whizzzkid commented 1 year ago

Describe your changes

Files changed

What issue(s) does this address?

Checklist before requesting a review

Checklist before merging

welcome[bot] commented 1 year ago

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

BigLep commented 1 year ago

Per https://github.com/ipfs/ipfs-companion/issues/1220#issuecomment-1597277883, I would encourage removing this all-together. I assume we aren't testing this functionality and it's not supported. As a result, I don't see value in advertising it.

whizzzkid commented 1 year ago

@SgtPooki the checks seem to be failing because of an error link in a file that didn't change. merge with errors? 🤔

ElPaisano commented 1 year ago

@whizzzkid are there any other changes you'd like to make before I merge this into https://github.com/ipfs/ipfs-docs/tree/js-ipfs-cleanup for final cleanup and merging?