search

ipfs / ipfs-gui

Creating standards and patterns for IPFS that are simple, accessible, reusable, and beautiful
104 stars 19 forks source link

remove js-ipfs related deps #137

Open SgtPooki opened 1 year ago

SgtPooki commented 1 year ago 
### Tasks
- [ ] remove ipfs
- [ ] remove ipfs-core-utils
- [ ] remove ipfs-provider
- [ ] remove is-ipfs
SgtPooki commented 1 year ago

the IPNS publishing fails when I remove the js-ipfs support from ipfsdCtl in ipfs-backend.js for e2e tests, and pass when I leave it alone:

results of npx playwright test -c ./test/e2e --repeat-each 10

 5 failed
    ipns.test.js:34:5 › IPNS publishing › Settings screen › should support adding new keys ─────────
    ipns.test.js:29:5 › IPNS publishing › Settings screen › should list IPNS keys ──────────────────
    ipns.test.js:85:5 › IPNS publishing › Files screen › should have functional "Publish to IPNS" context action
    ipns.test.js:85:5 › IPNS publishing › Files screen › should have functional "Publish to IPNS" context action
    ipns.test.js:85:5 › IPNS publishing › Files screen › should have functional "Publish to IPNS" context action
  355 passed (3.0m)
SgtPooki commented 1 year ago

I reverted changes to ipfs-backend.js and re-ran npx playwright test -c ./test/e2e --repeat-each 10 and got 

  5 failed
    explore.test.js:181:5 › Explore screen › Inspecting CID › should open dag-pb unixFS XKCD Archives
    explore.test.js:181:5 › Explore screen › Inspecting CID › should open dag-pb unixFS XKCD Archives
    ipns.test.js:85:5 › IPNS publishing › Files screen › should have functional "Publish to IPNS" context action
    ipns.test.js:85:5 › IPNS publishing › Files screen › should have functional "Publish to IPNS" context action
    ipns.test.js:85:5 › IPNS publishing › Files screen › should have functional "Publish to IPNS" context action