File previews not working in Explore section - Githubissues

ipfs / ipfs-webui

A frontend for an IPFS Kubo and IPFS Desktop

https://webui.ipfs.io

MIT License

1.53k stars 474 forks source link

File previews not working in Explore section #1368

Open bajtos opened 4 years ago

bajtos commented 4 years ago

Steps to reproduce

Launch ipfs-desktop
Open "Explore" section
Go to "XKCD" sample
Open one of the entries, e.g. 10 - Pi Equals
Open the image entry, e.g. 10 - Pi Equals.png

Actual outcome

Preview is not available. User has to view the image via IPFS gateway link provided by the app (e.g. http://127.0.0.1:8080/ipfs/QmbvrHYWXAU1BuxMPNRtfeF4DS2oPmo5hat7ocqAkNPr74).

Screenshot:

ipfs-desktop-screenshot

Expected outcome

Image preview is displayed in the app.

Mockup:

ipfs-desktop-mockup

Additional information

ipfs-desktop version: v0.10.2
tested on MacOS and Windows
AFAICT, ipfs-webui does provide file preview functionality, see https://github.com/ipfs-shipyard/ipfs-webui/blob/1eef40c9f8bf5c135f21fd80ae739405ff6da8e9/src/files/file-preview/FilePreview.js
Based on the discussion in https://github.com/ipfs-shipyard/ipfs-desktop/issues/785, it seems like file previews are supposed to work in ipfs-desktop. Maybe they are not implemented in Explore UI yet?

hacdias commented 4 years ago

The File Preview is for the Files section and not the Explore section. They are not supposed to work on Explore. This would be a new feature. I'm moving this to IPFS Web UI repository, but as far as I know, there is no intention to implement this on the Explore section.