search

ipfs / ipfs-webui

A frontend for an IPFS Kubo and IPFS Desktop
https://webui.ipfs.io
MIT License
1.56k stars 489 forks source link

React Joyride bug: Node info pop-up dynamic issues on a smaller screen #1470

Open davenes8148 opened 4 years ago

davenes8148 commented 4 years ago

Describe the bug Node Info pop up – The pop up appears over the highlighted section that it's trying to display, I would have thought the pop up would be below with an arrow pointing up so you can see the whole section (This does move when you scroll down so maybe just needs to be made more dynamic)

To Reproduce Steps to reproduce the behavior:

  1. Go to the Status page
  2. Click on the help text icon
  3. Click next until you hit page 3
  4. View the position of the help text over the highlighted area

Expected behavior If your looking on a big screen, the help text will be displayed above the highlighted area (if there's enough space on the screen, so it doesn't, get blocked If you're on a smaller screen as I am then it will be displayed underneath again so the highlighted are doesn't get blocked.

Screenshots image

Desktop (please complete the following information):

jessicaschilling commented 4 years ago

This is a React Joyride issue, but the visual impact is significant enough that we should see if it's something we can work around on our end. Marking for later prioritization, but if anyone wants to take a bash in the meantime, more than welcome!

NOTE: There are also related issues in https://github.com/ipfs-shipyard/ipfs-desktop/issues/1445 and https://github.com/ipfs-shipyard/ipfs-webui/issues/1462.