ipfs / ipfs-webui

A frontend for an IPFS Kubo and IPFS Desktop
https://webui.ipfs.io
MIT License
1.56k stars 490 forks source link

Custom "API ADDRESS" field communicate what the valid address is #1553

Open Gozala opened 4 years ago

Gozala commented 4 years ago

Per https://github.com/ipfs-shipyard/ipfs-webui/issues/1541#issuecomment-662421803 current language regarding custom API address can be misleading because:

  1. webui can not dial arbitrary addresses (e.g. https://webui.ipfs.io/ won't be able to dial any http:// address other than loopaback address.
  2. Safari can't dial any http address
  3. IPFS desktop could probably dial any address
  4. Some addresses may not provide CORS headers to allow dialing

I think we can do better by validating inputs and providing contextual information e.g.

jessicaschilling commented 4 years ago

@Gozala Is this something you have the bandwidth to take on? (In any case, can you please label the issue accordingly? Thanks!)

Gozala commented 4 years ago

@jessicaschilling I'm afraid I still don't have privileges to assign labels. I don't think I have bandwidth right now to take on this issue.