ipfs / ipfs-webui

A frontend for an IPFS Kubo and IPFS Desktop
https://webui.ipfs.io
MIT License
1.56k stars 488 forks source link

setting Public Gateway but it ignores my custom port in url and returns error #2077

Open mrhaoxx opened 1 year ago

mrhaoxx commented 1 year ago

Describe the bug when i configure the webui,i has a self-hosted public gateway eposing in a url with custom port "https://ipfs.xxx.com:1234" but when i submit url, it ignored my port and becomes "https://ipfs.xxx.com"

welcome[bot] commented 1 year ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

Finally, remember to use https://discuss.ipfs.io if you just need general support.

whizzzkid commented 1 year ago

@haoxingxing thanks for submitting the issue, I think some effort would be needed to reproduce this. On initial look it might be a bug with multiformats lib which might be assuming no additional ports with https (defaults to 443). This is a weird edge case, would you like to investigate and submit a PR for this issue?

mrhaoxx commented 1 year ago

I knew little about js so it might be difficult for me to direct contribute to the code.

But i think the issue is a local problem because it is normal to set the ipfs api address with custom port the two settings (api/public gateway) should have similar processing logic but one is normal and the other not

mrhaoxx commented 1 year ago