search

ipfs / ipfs-webui

A frontend for an IPFS Kubo and IPFS Desktop
https://webui.ipfs.io
MIT License
1.57k stars 490 forks source link

chore: use lts node version in CI #2259

Closed SgtPooki closed 1 week ago

SgtPooki commented 2 months ago

Updates all github workflows selections of node-version to be "lts/*"

SgtPooki commented 1 month ago

is lts/* useful in CI of rarely-maintained apps? i remember the same breackage occuring 12→14→16→18 (nearly every time a change of LTS image broke CI in one of our legacy JS apps)

most likely not, but we probably want to see a failure when it occurs right?

maybe hardcode to 20.x to avoid headache? (not feeling strongly, i'd just rather not deal with problem once LTS breaks again)

That is good with me, but we should probably target 22 now since it's going active very soon

image

SgtPooki commented 1 month ago

I think once I get https://github.com/ipfs/ipld-explorer-components/pull/448 done, we will be closer to updating everything here.

SgtPooki commented 1 week ago

done in https://github.com/ipfs/ipfs-webui/pull/2283