ipfs / ipfs-webui

A frontend for an IPFS Kubo and IPFS Desktop
https://webui.ipfs.io
MIT License
1.55k stars 482 forks source link

UI: bandwith stats have the colors the wrong way around #953

Closed nonchip closed 5 years ago

nonchip commented 5 years ago

I'm on Revision 1ed2020, and I just noticed on the Status tab of the webUI the colors for inbound/outbound traffic differ:

those should probably be swapped so they match up for easier recognition at a glance.

fsdiogo commented 5 years ago

Hi @nonchip, this has been fixed in v2.2.0!

nonchip commented 5 years ago

@fsdiogo i just realized my distro didn't update the package since 0.4.18, thanks for pointing out :P

nonchip commented 5 years ago

@fsdiogo actually, that's also the latest release on dist.ipfs.io and the go-ipfs github repo, am I missing something here? 0.o

EDIT: ok, found the problem, makes sense, the webui vs daemon are updated independently, and https://github.com/ipfs/go-ipfs/blob/master/core/corehttp/webui.go#L4 is still not a ipns address.

fsdiogo commented 5 years ago

Well, what's happening is that you're using the latest "production" version of go-ipfs which has a specific version of the Web UI (the one you're using).

With every release of the Web UI we PR the repos that use it, such as go-ipfs (https://github.com/ipfs/go-ipfs/pull/5855, https://github.com/ipfs/go-ipfs/pull/5899, https://github.com/ipfs/go-ipfs/pull/5928), but then it's up to those repos to be released so you can access the newest Web UI through them.

So, the next version of go-ipfs will already have the newer Web UI!

nonchip commented 5 years ago

guess i'll just wait then (and hope it's gonna become a name instead of a hash, it already seems to be on TXT _dnslink.webui.ipfs.io. anyway, so it'll be a bit more future proof).

by the way, note just going to webui.ipfs.io doesn't work if you use the companion plugin, because then it rewrites your url to use the gateway instead of api port, and specifying it manually breaks the CORS rules.

just checked, disabling the companion still breaks CORS, so um, the link in the v2.2.0 post does nothing :P