search

ipfs / ipfs-webui

A frontend for an IPFS Kubo and IPFS Desktop
https://webui.ipfs.io
MIT License
1.55k stars 482 forks source link

Remove non-default locales from the repo #954

Closed olizilla closed 5 years ago

olizilla commented 5 years ago

We should remove all the locale files from the repo and and them to the .gitignore, and update the docs and run scripts to fetch them on postinstall.

Having generated artefacts in a repo always leads to trouble eventually, and in this case it sets us up to waste the time of people who volunteer to fix translation issues.

See #950

lidel commented 5 years ago

@olizilla removing locales from repo will introduce various issues. I am against mainly for two reasons:

  1. Builds are no longer reproducible in offline mode + require access to the internet and Transifex API
    • Third party web service can break our builds
    • Also, I am not sure if you can fetch locales without account on Transifex and API key in ~/.transifexrc, which complicates CI and local setups for drive-by contributors
  2. We will be getting an amazing improvement for translations soon, but it needs locales to be present in repos (added you to email thread with Transifex, tl;dr is in https://github.com/ipfs/i18n/issues/5)

To avoid people submitting PRs with translations, we could:

lidel commented 5 years ago

Also, I suggest we always close PRs that bypass Transifex (eg. https://github.com/ipfs-shipyard/ipfs-webui/pull/950 - should close without merging).

Gently thank for translation and ask them to apply changes via Transifex or just link to ipfs/i18n#how-can-i-contribute-translation-for-my-language