0.8.0 fails to build with the latest go: cannot use "quic-go doesn't build on Go 1.18 yet." (untyped string constant) as int value in variable declaration

ipfs / ipget

Retrieve files over IPFS and save them locally.

MIT License

388 stars 54 forks source link

0.8.0 fails to build with the latest go: cannot use "quic-go doesn't build on Go 1.18 yet." (untyped string constant) as int value in variable declaration #104

Closed yurivict closed 2 years ago

yurivict commented 2 years ago

github.com/lucas-clemente/quic-go/internal/qtls
# github.com/lucas-clemente/quic-go/internal/qtls
vendor/github.com/lucas-clemente/quic-go/internal/qtls/go118.go:6:13: cannot use "quic-go doesn't build on Go 1.18 yet." (untyped string constant) as int value in variable declaration

OS: FreeBSD 13

welcome[bot] commented 2 years ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

"Priority" labels will show how urgent this is for the team.
"Status" labels will show if this is ready to be worked on, blocked, or in progress.
"Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

aschmahmann commented 2 years ago

https://github.com/lucas-clemente/quic-go/wiki/quic-go-and-Go-versions

Basically, this can get resolved once go-ipfs updates to a version of QUIC that supports 1.18. See the link for more details.

yurivict commented 2 years ago

Any chance to resolve this? Currently ipget fails to build with the latest version of Go.

yurivict commented 2 years ago

go-ipfs is at 0.12.2, but ipget still uses 1.11

lidel commented 2 years ago

latest go-ipfs 0.13-rc1 builds fine with golag 1.18, so if someone wants to work on this:

ipget needs to be updated at least to that version of go-ipfs, and also bump go-libp2p to 0.19 or later

yurivict commented 2 years ago

0.8.1 still has this problem.

I think I should just remove the port because the project is broken for months.

dmgk commented 2 years ago

Polite ping. go-ipfs currently is at v0.13.0, and builds fine with go1.18.

Stebalien commented 2 years ago

This will be fixed by #110. Unfortunately, that's blocked on https://github.com/ipfs/go-ipfs-http-client/pull/160.

lidel commented 2 years ago

Should be fixed in v0.9.x: https://dist.ipfs.io/ipget