ipfs / ipget

Retrieve files over IPFS and save them locally.
MIT License
388 stars 54 forks source link

fix: update app.Version to match with 0.10.0 release #147

Closed chenrui333 closed 1 month ago

chenrui333 commented 10 months ago

closes #146

relates to https://github.com/Homebrew/homebrew-core/pull/151569

welcome[bot] commented 10 months ago

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

aschmahmann commented 10 months ago

@chenrui333 can you make this v0.10.1, we already have a v0.10.0 tag so this won't quite match up. Thanks for the report and PR.

chenrui333 commented 9 months ago

@chenrui333 can you make this v0.10.1, we already have a v0.10.0 tag so this won't quite match up. Thanks for the report and PR.

totally!

chenrui333 commented 9 months ago

@aschmahmann let me know if it works better now.

github-actions[bot] commented 9 months ago

Suggested version: v0.10.1

Comparing to: v0.10.0 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# diagnostics
required module github.com/microcosm-cc/bluemonday@v1.0.1 retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.10.1

gocompat says:

Your branch is up to date with 'origin/master'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files. The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate. Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

Pre-creating GitHub Releases on release PRs initiated from forks is not supported. If you wish to prepare release notes yourself, you should create a draft GitHub Release for tag v0.10.1 manually. The draft GitHub Release is going to be published when this PR is merged. If you choose not to create a draft GitHub Release, a published GitHub Released is going to be created when this PR is merged.

gammazero commented 1 month ago

As per #113 version.json should be the source of truth. @chenrui333 Thank you for this PR, but I think #149 is preferable as it compiles the version in, using he value from version.json