Closed chenrui333 closed 1 month ago
Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:
The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
Your contribution itself is clear (code comments, self-review for the rest) and in its best form. Follow the code contribution guidelines if they apply.
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:
A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
The PR gets reviews, discussed and approvals as needed.
The PR is merged by maintainers when it has been approved and comments addressed.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!
@chenrui333 can you make this v0.10.1, we already have a v0.10.0 tag so this won't quite match up. Thanks for the report and PR.
@chenrui333 can you make this v0.10.1, we already have a v0.10.0 tag so this won't quite match up. Thanks for the report and PR.
totally!
@aschmahmann let me know if it works better now.
Suggested version: v0.10.1
Changes in go.mod
file(s):
(empty)
gorelease
says:
# diagnostics
required module github.com/microcosm-cc/bluemonday@v1.0.1 retracted by module author: Retract older versions as only latest is to be depended upon
# summary
Suggested version: v0.10.1
gocompat
says:
Your branch is up to date with 'origin/master'.
This PR is modifying both version.json
and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to master
. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.
Pre-creating GitHub Releases on release PRs initiated from forks is not supported.
If you wish to prepare release notes yourself, you should create a draft GitHub Release for tag v0.10.1
manually.
The draft GitHub Release is going to be published when this PR is merged.
If you choose not to create a draft GitHub Release, a published GitHub Released is going to be created when this PR is merged.
As per #113 version.json
should be the source of truth. @chenrui333 Thank you for this PR, but I think #149 is preferable as it compiles the version in, using he value from version.json
closes #146
relates to https://github.com/Homebrew/homebrew-core/pull/151569