Created library "get" that allows us to use ipget with code more easily.

faddat commented 3 years ago

go 1.17
re-organized so that we now have a library, "get"

welcome[bot] commented 3 years ago

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
Your contribution itself is clear (code comments, self-review for the rest) and in its best form. Follow the code contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
The PR gets reviews, discussed and approvals as needed.
The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

faddat commented 3 years ago

do you want to upgrade CI, or should I downgrade?

faddat commented 3 years ago

I think this is ready to go

gammazero commented 3 years ago

@faddat Thank you for your interest in contributing to this project. Unfortunately, this is not currently the direction we want to go with ipget. We would prefer that a library, that wraps the ability to connect to a local or remote node or create a temporary node to fetch data from IPFS, exists as a separate project/repo.

I would recommend reusing your work here to create a project that does just that. At some point in the future, such a library may be used to replace the functionality inside ipget, making ipget a CLI utility built on top of that library. Or maybe ipget is eventually replaced by a cmd within that library repo.

Again, thank you, but I am closing this PR for the reason stated above.

faddat commented 3 years ago

Very fair, I was just thinking about the same thing.

faddat commented 3 years ago

Here's what I am thinking:

remove other code from my fork
Include an example app in my fork
Rename the whole thing "get"

wdyt?

ipfs / ipget

Created library "get" that allows us to use ipget with code more easily. #91