search

ipfs / iptb

InterPlanetary TestBed 🌌🛌
MIT License
163 stars 39 forks source link

--wait times out when --bootstrap=none is provided #6

Open hackergrrl opened 8 years ago

hackergrrl commented 8 years ago 
stephen // tmp $ iptb start --bootstrap=none --wait
Started daemon 0, pid = 15548
ipfs start err:  node at 127.0.0.1:5002 failed to bootstrap in given time period

It'd be nice in this case (when --bootstrap=none is given) to wait /wo timeout, since the user may manually be bootstrapping later. It'd be good to keep the daemons around.

whyrusleeping commented 8 years ago

Ah yeah, i needed to document that --wait currently doesnt work with --bootstrap=none. You can just run it without --wait if you want to bootstrap on your own.

hackergrrl commented 8 years ago

To be clear: I'd still really like --wait to delay until nodes are bootstrapped, even if I'm doing it out-of-band.

whyrusleeping commented 8 years ago

hrm.... thats hard because iptb needs to know how many nodes to wait for on the bootstrap. It has no easy way of knowing when you are done bootstrapping, if done out of band. What is your usecase?

hackergrrl commented 8 years ago

I think my real balk is making the semantics of --wait really clear: having it terminate when all of my nodes are NOT bootstrapped is inconsistent with the "waits until nodes are bootstrapped" promise. Either changing the docs to reflect this or disallowing --bootstrap=none with --wait could work.