ipfs / js-ipfs-unixfs

JavaScript implementation of IPFS' unixfs (a Unix FileSystem representation on top of a MerkleDAG)
Other
87 stars 34 forks source link

Align sharding threshold detection #149

Closed achingbrain closed 1 year ago

achingbrain commented 3 years ago

go-IPFS has taken a different approach to js-IPFS in deciding when to start using a HAMT shard instead of a regular directory.

js-IPFS has an arbitrary 1k entry limit, overridable by the user.

go-IPFS calculates the likely block size of the directory node, sharding once it increases above a certain size.

We should align with the go-IPFS calculation, in order to not have divergent hashes for a given directory.

Ref: https://github.com/ipfs/go-ipfs/issues/7022#issuecomment-832178501

tinytb commented 1 year ago

2022-11-22: still needs to be done; no time pressure.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version ipfs-unixfs-v10.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version ipfs-unixfs-importer-v13.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version ipfs-unixfs-exporter-v11.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: