ipfs / js-ipfs-unixfs

JavaScript implementation of IPFS' unixfs (a Unix FileSystem representation on top of a MerkleDAG)
Other
87 stars 34 forks source link

fix: add cross-impl shard test, fix path cleaner #358

Closed rvagg closed 1 year ago

rvagg commented 1 year ago

Ref: https://github.com/ipfs/go-unixfsnode/pull/66

The material change in here is the path cleaner/splitter; it's a bit too aggressive. It doesn't allow \ as a file name and the .trim() discounts valid file names. Otherwise this is a match for https://github.com/ipfs/go-unixfsnode/pull/66 and gets the same CID on importer, and tests the exporter can read the same data.

achingbrain commented 1 year ago

Thanks!