ipfs.add fails with TypeError: "can't convert undefined to object"

[lidel]

• Version: 0.36.0, prebuild browser bundle
• Platform: web browser (Chrome & Firefox)
• Subsystem: ipfs.add

Type: Bug

Severity: High

Description:

ipfs.add with prebuilt bundle for use in browser produces error:

Steps to reproduce the error:

I prepared two apps to demonstrate the issue:

• ipfs.add under 0.35.0 using Buffer: demo works ok
  • replace js-ipfs with 0.36.0 and it will fail
• ipfs.add under 0.36.0 using File: demo fails

[alanshaw]

https://github.com/ipld/js-ipld-dag-pb/blob/d02c65918e537380ad2844b2573283def30098b4/src/dag-node/addNamedLink.js#L14 should be Object.keys(object) not Object.keys(this).

[alanshaw]

@hugomrdias any chance you can look into why this wasn't caught in our browser tests?

[vmx]

I've opened https://github.com/ipfs/aegir/issues/362 to track the issue on Browser tests not running against the same code as the dist bundle contains.