ipfs / js-ipfs

IPFS implementation in JavaScript
https://js.ipfs.tech
Other
7.44k stars 1.25k forks source link

An in-range update of libp2p-kad-dht is breaking the build 🚨 #2308

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The dependency libp2p-kad-dht was updated from 0.15.2 to 0.15.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

libp2p-kad-dht is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ✅ **bundlesize:** ./dist/index.min.js: 688.21KB < maxSize 689KB (gzip) ([Details](https://bundlesize-store.now.sh/build?info=%7B%22files%22%3A%5B%7B%22maxSize%22%3A705536%2C%22path%22%3A%22.%2Fdist%2Findex.min.js%22%2C%22size%22%3A704724%2C%22compression%22%3A%22gzip%22%7D%5D%2C%22repo%22%3A%22ipfs%2Fjs-ipfs%22%2C%22branch%22%3A%22greenkeeper%2Flibp2p-kad-dht-0.15.3%22%2C%22commit_message%22%3A%22chore(package)%3A%20update%20libp2p-kad-dht%20to%20version%200.15.3%22%2C%22sha%22%3A%22a5f8844f5d9ff7e3dde53fe05ee38c3e6ce1093b%22%7D)). - ✅ **codecov/patch:** Coverage not affected when comparing 63eb5db...a5f8844 ([Details](https://codecov.io/gh/ipfs/js-ipfs/commit/a5f8844f5d9ff7e3dde53fe05ee38c3e6ce1093b)). - ✅ **codecov/project:** 86.61% remains the same compared to 63eb5db ([Details](https://codecov.io/gh/ipfs/js-ipfs/commit/a5f8844f5d9ff7e3dde53fe05ee38c3e6ce1093b)). - ❌ **Travis CI - Branch:** The build **failed**.

Release Notes for v0.15.3

Bug Fixes

  • _findNProvidersAsync discarding search results (#137) (e656c6b)
Commits

The new version differs by 8 commits.

  • 83ce93d chore: release version v0.15.3
  • 58a4592 chore: update contributors
  • e656c6b fix: _findNProvidersAsync discarding search results (#137)
  • c9093c4 docs: add link to kademlia paper (#136)
  • b36b871 docs: implementation summary (#135)
  • a8f1df5 refactor(async): random-walk (#134)
  • 30fd44a refactor(async): providers refactor
  • 9e777e5 refactor(async): query functions are now async functions

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 0.15.2 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

alanshaw commented 5 years ago

resolved in https://github.com/ipfs/js-ipfs/pull/2312