ipfs / js-ipfs

IPFS implementation in JavaScript
https://js.ipfs.tech
Other
7.44k stars 1.25k forks source link

Converting to TypeScript? #4059

Closed cyphercider closed 1 year ago

cyphercider commented 2 years ago

Hi! I looked through the issue history to see if there has been a deliberate discussion around this topic, and I wasn't able to find one. Apologies if this has been discussed and this is a repeat.

I've noticed while working in the IPFS ecosystem that the JS Ipfs implementation seems to have a handful of stability challenges, as well as recurring issues around accuracy of published typings. Is a conversion to TypeScript something that has been considered to help address these? Since js-ipfs is a monorepo, piecemeal conversion of the repo by community contributors may be a practical way to complete a full conversion while conserving core team effort.

welcome[bot] commented 2 years ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

Finally, remember to use https://discuss.ipfs.io if you just need general support.

Winterhuman commented 2 years ago

There's this issue in js-libp2p: https://github.com/libp2p/js-libp2p/issues/1021

So I'd imagine TypeScript support in js-ipfs would come after this issue is closed, I don't think there's any official plan or roadmap for this documented anywhere.

SgtPooki commented 2 years ago

@achingbrain is this something on your schedule?

BigLep commented 2 years ago

@cyphercider: there is no plan currently to convert js-ipfs to typescript. We have typedefinintions. We are active (almost done) on converting js-libp2p (https://github.com/libp2p/js-libp2p/issues/1021 ). We'll have more to share in the next month or so about how we plan to evolve js-ipfs. We'll keep this open until we have a better issue for you to track/comment-on.

whizzzkid commented 1 year ago

js-ipfs is being deprecated in favor of Helia. You can follow the migration plan here https://github.com/ipfs/js-ipfs/issues/4336 and read the migration guide.

This issue has been resolved in Helia! if this does not address your concern please let us know by reopening this issue before 2023-06-05!