pleerock
commented
2 years ago doesn't it make sense to enable vite support? (or drop it from the examples if its not supported anymore)
Closed achingbrain closed 1 year ago
pleerock
commented
2 years ago doesn't it make sense to enable vite support? (or drop it from the examples if its not supported anymore)
achingbrain
commented
2 years ago Vite is supported, the example should pass now. It's not been synced into it's own repo because something has changed in github permissions around overwriting actions yml files - that's the failure of the sync build referred to above.
I haven't had time to get back to this - need to get the next libp2p release out, then the next ipfs release with that libp2p release, then we should be in a better place.
pleerock
commented
2 years ago I just checked vite example doesn't seem to work:
browser-vite % npm start
> example-browser-vide@1.0.0 start
> npm run serve
> example-browser-vide@1.0.0 serve
> vite dev --port 8888
VITE v3.0.1 ready in 155 ms
➜ Local: http://127.0.0.1:8888/
➜ Network: use --host to expose
✘ [ERROR] Big integer literals are not available in the configured target environment ("chrome87", "edge88", "es2020", "firefox78", "safari13" + 2 overrides)
../../node_modules/ipfs-core/src/ipns/publisher.js:193:20:
193 │ let seqNumber = 0n
╵ ~~and producing bunch of other bigint related errors. Weird issue, seems like vite doesn't catch up it's vite.config.js
pleerock
commented
2 years ago Weird. Config is read by vite, but not applied?
achingbrain
commented
2 years ago Sometimes you have to specify the config file explicitly with the command line --config arg?
pleerock
commented
2 years ago Same thing. You can see in the output I sent above - it does read the config, but still getting this error. I think if you try to pull the latest from the master, go to ./examples/browser-vite and run npm start - you'll see the same issue.
inverted-capital
commented
2 years ago @pleerock that issue with vite is solved by adding target: 'es2020' to your config:
export default defineConfig({
optimizeDeps: {
// target: es2020 added as workaround to make big ints work
// https://github.com/vitejs/vite/issues/9062#issuecomment-1182818044
esbuildOptions: {
target: 'es2020',
},
}
})@inverted-capital current config already has esnext which includes es2020, but it still doesn't work (for some reason).
pleerock
commented
2 years ago @inverted-capital oh I just noticed that you were talking about "optimizeDeps. esbuildOptions" option and not just "build" option. Thanks, that works! Somewhat should definitely create a PR to fix the issue in the examples.
achingbrain
commented
1 year ago There is a vite example available for Helia here - https://github.com/ipfs-examples/helia-vite
All except vite because the sync build is failing