ipfs / js-ipfs

IPFS implementation in JavaScript
https://js.ipfs.tech
Other
7.44k stars 1.25k forks source link

DisableNatPortMap incorrectly documented? #4236

Closed Sjord closed 1 year ago

Sjord commented 1 year ago

In CONFIG.md:

By default when running under nodejs, libp2p will try to use UPnP to open a random high port on your router for any TCP connections you have configured.

Set DisableNatPortMap to false to disable this behaviour.

However, I think this behaviour is disabled by setting DisableNatPortMap to true. Is that right? The Disable part of this setting inverses the setting.

welcome[bot] commented 1 year ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

Finally, remember to use https://discuss.ipfs.io if you just need general support.

achingbrain commented 1 year ago

Yes, this is incorrect - would you like to submit a quick PR that corrects the docs?