search

ipfs / js-ipfs

IPFS implementation in JavaScript
https://js.ipfs.tech
Other
7.43k stars 1.25k forks source link

improve dockerfiles #4275

Closed sevenrats closed 1 year ago

sevenrats commented 1 year ago

improve dockerfiles by removing unnecessary layers and greatly reducing size. remove sed line that causes insecure exposure -- users must use proper configs. adds a proper init, catatonit, selected for modern signal handling.

sevenrats commented 1 year ago

worth mentioning, probably, that this configuration removes the package manager, apk, so, it would be impractical to build containers out of this one. I think it's appropriate to remove i if the container is not explicitly a base layer for other stuff, but it's up to you guys.

sevenrats commented 1 year ago

contains a bug where will always init because $IPFS_PATH is not a file, change to -d or point to PATH/config

achingbrain commented 1 year ago

Thank you so much for opening this PR and for your patience in getting it merged. js-ipfs is being deprecated in favor of Helia. You can https://github.com/ipfs/js-ipfs/issues/4336 and read the migration guide.

Sorry we never got to this.