Migrate to using undici instead of node-fetch

FlattestWhite commented 1 year ago

Addresses: https://github.com/ipfs/js-ipfs/issues/4243

welcome[bot] commented 1 year ago

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
Your contribution itself is clear (code comments, self-review for the rest) and in its best form. Follow the code contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
The PR gets reviews, discussed and approvals as needed.
The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

BigLep commented 1 year ago

@FlattestWhite : just curious why you closed this.

FlattestWhite commented 1 year ago

@FlattestWhite : just curious why you closed this.

Ah I think I was running into some issues with some of the tests, got busy and then figured since I wasn't able to come back to this for a while, I closed it. I can open it back up and try and figure out the testing problem - if you think it's worth it.

edit: Just to be clear, it wasn't the tests in this PR that I enabled that were broken. These ones seemed to have passed. However, some other existing tests around econnrefused seemed to have changed behaviour.

BigLep commented 1 year ago

Hi @FlattestWhite . No pressure to open it, I was more just curious what caused you to abandon it. I can't accurately to the priority. Maintainer energy is starting to shift to https://github.com/ipfs/helia, and I don't know how relevant this work is for that effort.

FlattestWhite commented 1 year ago

Hi @FlattestWhite . No pressure to open it, I was more just curious what caused you to abandon it. I can't accurately to the priority. Maintainer energy is starting to shift to https://github.com/ipfs/helia, and I don't know how relevant this work is for that effort.

Ahhh thanks for letting me know. Yeah I don't think this PR is worth keeping open then. Especially since a rewrite is now happening. This PR doesn't move the needle, and it was more for my open purpose of exploring the code base while contributing something.

ipfs / js-ipfs

Migrate to using undici instead of node-fetch #4290