ipfs / js-ipfs

IPFS implementation in JavaScript
https://js.ipfs.tech
Other
7.44k stars 1.25k forks source link

Consider removing or replacing `update-notifier`? #4322

Closed jimmywarting closed 1 year ago

jimmywarting commented 1 year ago

I personally think that the drawbacks from keeping a update notifier outweigh the benefits:

I suggest that you just use npm deprecate js-ipfs@x new version available, update to x.y.z

An alternative is a more minimal cross compatible Deno / Bun /Browser (\w CORS support) package called: update-notifier-go

welcome[bot] commented 1 year ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

Finally, remember to use https://discuss.ipfs.io if you just need general support.

achingbrain commented 1 year ago

Thanks for opening this - js-IPFS is in the process of being deprecated, the replacement is Helia which is a bit more minimal and doesn't have extra deps like this.

The intention behind including this sort of module is to prompt a user who has js-IPFS installed as a CLI tool to upgrade, they typically don't npm i it every day so they wouldn't see the notifications from npm deprecate.

Your replacement module looks interesting though thanks for the link!