feat: change default TTL and add support for custom TTL (#1)

jtsmedley commented 8 months ago

Changes the Default TTL to the suggested default of 1 hour per the ipns-record spec
Allows for a custom TTL to be passed

welcome[bot] commented 8 months ago

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
Your contribution itself is clear (code comments, self-review for the rest) and in its best form. Follow the code contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
The PR gets reviews, discussed and approvals as needed.
The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

jtsmedley commented 6 months ago

Ran linter, updated tests to support new TTL check and added 2 new tests for custom TTL.

achingbrain commented 6 months ago

@jtsmedley the tests are failing - could you take a look please?

achingbrain commented 6 months ago

Thanks!

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 9.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ipfs / js-ipns

feat: change default TTL and add support for custom TTL (#1) #308