search

ipfs / js-kubo-rpc-client

A client library for the Kubo RPC API
https://www.npmjs.com/package/kubo-rpc-client
Other
33 stars 7 forks source link

fix: export createKuboRPCClient function #224

Closed achingbrain closed 3 weeks ago

achingbrain commented 5 months ago

The create function is too generic, it often clashes with other functions so export a copy with a more obvious name.

SgtPooki commented 5 months ago

We should update readme too

achingbrain commented 5 months ago

I don't know if we want something more pithy - createKuboClient or something?

SgtPooki commented 5 months ago

I think whatever works is fine. Im not a fan of uppercase acronyms in camel/pascal case "RPCClient" but its not something we need to type much

SgtPooki commented 5 months ago

Also, This is technically a breaking change, but we did just release as v14 🤔

achingbrain commented 5 months ago

It’s not breaking because it’s a re-export of the existing symbol, not a straight rename so all good on that front.

github-actions[bot] commented 3 weeks ago

:tada: This PR is included in version 4.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: