ipfs-http-client migration: Additional tasks

SgtPooki commented 1 year ago

For the full context see https://github.com/ipfs/kubo/issues/9125

Broken during migration

High priority items

[ ] #94
[ ] #77

Other items

[x] IPNS tests - https://github.com/ipfs/js-kubo-rpc-client/pull/83#discussion_r1035136205
- Seems to work locally, a9b2b71 (#83)
[x] 'should get a directory' tests - https://github.com/ipfs/js-kubo-rpc-client/pull/83#discussion_r1035136704
- Fixed: cb2566a (#83)
[x] ''should pin dag-cbor' - intermittent failures on webworkers https://github.com/ipfs/js-kubo-rpc-client/pull/83#discussion_r1035138501
- Unskipped, seems to be working with latest updates. 65d42f1 (#83)
[ ] 'should default to blocking pin' - intermittently failing for chrome only. see
[ ] 'should fail to find other peer if peer does not exist'
- Kubo added Delegated Routing over HTTP, deprecated ipfs dht and switched to ipfs routing which uses all defined routers – probably related to these changes, Antonio may help in debugging this.
[ ] #98
[ ] undici fetch causing issues. see https://github.com/ipfs/js-kubo-rpc-client/pull/83#discussion_r1048502885
[x] https://github.com/ipfs/js-kubo-rpc-client/issues/97

Broken prior to migration

[ ] #144
- see https://github.com/ipfs/js-ipfs/issues/3547
- Kubo supports different format than JS-IPFS – see https://github.com/ipfs/go-ipfs/pull/8616/
- see https://github.com/ipfs/kubo/issues/9508
- PEM export not yet supported in Libp2p: https://github.com/libp2p/js-libp2p-crypto/issues/244
[ ] https://github.com/ipfs/js-kubo-rpc-client/issues/66
[ ] Intermittent failures after merging #83,
- [ ] 'should respect timeout option when querying the DHT' on macos:node
  - passed in https://github.com/ipfs/js-kubo-rpc-client/actions/runs/3708552206/jobs/6286726306
- [ ] '.pubsub.subscribe"after each" hook for ".onError when connection is closed"' on chrome:webworker
  - passed in https://github.com/ipfs/js-kubo-rpc-client/actions/runs/3708552206/jobs/6286726306

Removed tests that should be re-added

[ ] restore mode and mtime tests
- see https://github.com/ipfs/js-kubo-rpc-client/pull/83#discussion_r1048615611. "When https://github.com/ipfs/go-unixfs/pull/117 and https://github.com/ipfs/kubo/issues/6920 land, someone will want to restore these tests, but i think its fine to remove them for now (they will still be in git history)."

Skipped tests that are remaining skipped due to a bug (need investigation)

[ ] #95

BigLep commented 1 year ago

@SgtPooki : do we have a theory why copy/pasting the code out to js-kubo-rpc-client would be causing tests to fail (given we matched dependencies)?

SgtPooki commented 1 year ago

@SgtPooki : do we have a theory why copy/pasting the code out to js-kubo-rpc-client would be causing tests to fail (given we matched dependencies)?

@BigLep that's a great question.

I don't have a theory other than that one of the pinned deps from the ipfs, interface-ipfs-core, or ipfs-http-client got changed. This issue and above linked CI run was an attempt to remove any of those variables, but obviously it doesn't fix all the problems.

Other issues were called out in https://github.com/ipfs/js-kubo-rpc-client/issues/5#issuecomment-1281627929 and other comments on that thread.

There are also a few js-ipfs and proc being utilized in tests that we're now trying to test using only kubo-daemon. Are some of the tests, as written, dependent upon one of the nodes not being kubo? Probably. Do I know which ones yet? Nope.

I had a draft comment written up where I was going to show debug output from some of these failing tests and lost it. Long story short: without in-depth knowledge of whats going on in the daemon, libp2p, and the intricacies of these tests, it's going to take me a long time to solve all of these errors. That is why I argued (in kubo standup) for simply blocking them temporarily until a dev more experienced in this stack could take a look. (i.e. unblocking myself)

I can work on solving these, but I will need to bring in an expert for tests where existing debug output is not sufficient, docs are out of date, or failures are generally less obvious.

Now I'm trying to get this demo project done for next week, so I'll have to get back to diving into this later.

ipfs / js-kubo-rpc-client