chore: update go-libp2p-kad-dht

ipfs / kubo

An IPFS implementation in Go

https://docs.ipfs.tech/how-to/command-line-quick-start/

Other

15.83k stars 2.96k forks source link

chore: update go-libp2p-kad-dht #10100

Closed Jorropo closed 1 month ago

Jorropo commented 8 months ago

Depends on:

dennis-tra commented 8 months ago

I this PR superseded by https://github.com/ipfs/kubo/pull/10116?

BigLep commented 6 months ago

2023-11-09 maintainer conversation:

High level: we either need to be able to update or we revert the breaking changes in go-libp2p-kad-dht
We can't test WAN mode in the CI tests.
Going to make test setup / configuration to see if can get tests to pass.
Need to backlog the "better way" of handling. @Jorropo will write this.

BigLep commented 4 months ago

2024-01-04 maintainer conversation:

We don't know why 0.25 broke. We need to start here. Once we understand (and document) this, we will then figure out how we respond. (Getting understanding is the minimum requirement for 202401 Mercury).

guillaumemichel commented 2 months ago

go-libp2p-kad-dht v0.25.2 shouldn't be broken. However v0.25.0 introduced a change to prevent private addresses to land on the public Amino DHT, so some tests may need to be modified.

The following fix can be applied to tests failing because test nodes are using loopback/private addresses https://github.com/libp2p/go-libp2p-kad-dht/pull/839#issuecomment-1673690007

Reference: https://github.com/libp2p/go-libp2p-kad-dht/blob/088322b3bd36f384963225348a23f5723a2b80c3/dual/dual.go#L98-L127