Open gdkrmr opened 9 months ago
Thank you for surfacing this UX problem @gdkrmr.
Yes, this looks like a bug – add --nocopy
should error.
I think this is something not limited to FilestoreEnabled
,
we have many flags that don't take effect without restarting, such as entire Routing, including Routing.AcceleratedDHTClient.
This is a good opportunity to improve UX around config changes.
Flag
named RequiresRestart
and setting it to true
every time when config change is applied.
Pinning.RemoteServices
ipfs daemon
.ipfs add --nocopy
RequiresRestart
is set to true
, error asking user to restart first. ipfs add
, ipfs block put
, ipfs dag put|import
, ipfs files mkdir|write
– we will add ability to adjust default CID parmeters in the future, so config impact won't be limited to add --nocopy
ipfs routing provide
(impacted by AcceleratedDHTClient)ipfs name publish
(impacted by IPNS config params)`@gdkrmr can look into this? First time contributing to open source ;-), I would love just more guidance to work on this
Checklist
Installation method
ipfs-desktop
Version
Config
No response
Description
Changing the config
and then running (without restarting, as in the documentation)
will ignore the
--nocopy
and add everything as blocks. This should probably give an error.