search

ipfs / kubo

An IPFS implementation in Go
https://docs.ipfs.tech/how-to/command-line-quick-start/
Other
15.83k stars 2.96k forks source link

do we want to keep this interface as []string, #10336

Closed alexandrabeasley8 closed 2 weeks ago

alexandrabeasley8 commented 3 months ago

https://github.com/ipfs/kubo/blob/f4ff4f76dd0d54b7a9da1fa1ac64b163ea3d3a18/client/rpc/pubsub.go#L1-L214

aschmahmann commented 2 months ago

What's your concern/does it matter? We could convert it to []byte although I'm not sure if that would really make things easier for anyone and would change the public API.

github-actions[bot] commented 3 weeks ago

Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days.

github-actions[bot] commented 2 weeks ago

This issue was closed because it is missing author input.