core/node: prioritize announcing pin roots

ipfs / kubo

An IPFS implementation in Go

https://docs.ipfs.tech/how-to/command-line-quick-start/

Other

15.81k stars 2.96k forks source link

core/node: prioritize announcing pin roots #10376

Closed hacdias closed 3 weeks ago

hacdias commented 1 month ago

This should close #10365.

[x] Rewrite the provider and reprovider tests in Go
[x] Depends on https://github.com/ipfs/boxo/pull/595

aschmahmann commented 1 month ago

and figure out how on earth I will test that

A couple options that seem reasonable:

Don't fully test end-to-end and just test the functions that get implemented for announcements
Test end-to-end but with a chunk of code running that processes delegated provides (not sure what the state of these is at the moment)

Both of these would let you capture ordering without being that annoying (e.g. you could also run a custom DHT server node instead of using a delegated router for provides).