ipfs / kubo

An IPFS implementation in Go
https://docs.ipfs.tech/how-to/command-line-quick-start/
Other
16.19k stars 3.02k forks source link

refactor: simplify logic for MFS remote pinning #10506

Closed gammazero closed 1 month ago

gammazero commented 2 months ago

MFS pinning logic was returning errors on a channel, only to be logged by a separate goroutine. The errors were not used for any other purpose, so the logic could be significantly simplified by logging the error where it happened instead of returning it on a channel to be logged. This PR removes the unnecessary channel and logging goroutine.

A couple other minor simplifications and consistency changes were also made, such as passing a context as the first argument.