Remove shebang from shell completions

kpcyrd commented 1 week ago

Checklist

[X] This is a bug report, not a question. Ask questions on discuss.ipfs.tech.
[X] I have searched on the issue tracker for my bug.
[X] I am running the latest kubo version or have an issue updating.

Installation method

built from source

Version

Kubo version: 0.30.0
Repo version: 16
System version: amd64/linux
Golang version: go1.23.1

Config

No response

Description

hi!

I noticed the shell completions contain a shebang (#!/...) but shell completions are usually sourced instead of executed, so a shebang is not necessary.

For zsh it seems the completions are not working due to this:

% ipfs d<tab><tab>
(nothing happens)

lidel commented 4 days ago

@kpcyrd I am unable to reproduce, following https://github.com/ipfs/kubo/blob/master/docs/command-completion.md#zsh the eval "$(ipfs commands completion zsh)" works fine with zsh 5.9.

Perhaps you are using something else? IF so, why? Are there other docs related to this that we should update?

kpcyrd commented 4 days ago

I'm not sure if eval is the right way to test this, in my case the completions are loaded from /usr/share/zsh/site-functions/_ipfs.

The _ipfs file I use is sha256:001becd85257c39b452858b2371680fcf936b587c94d845bd8fd2e7c17f2df21.

ipfs / kubo