ipfs / kubo

An IPFS implementation in Go
https://docs.ipfs.tech/how-to/command-line-quick-start/
Other
16.18k stars 3.02k forks source link

Accept symbolic links as mounting scripts in the Docker image #10519

Closed jesusvico closed 1 month ago

jesusvico commented 2 months ago

Checklist

Description

Now, only regular files are accepted as valid mounting scripts in the Docker image.

# /kubo/bin/container_daemon

#...

find /container-init.d -maxdepth 1 -type f -iname '*.sh' -print0 | sort -z | xargs -n 1 -0 -r container_init_run

This could be fixed with the following change:

find /container-init.d -maxdepth 1 \( -type f -o -type l \) -iname '*.sh' -print0

When using Kubernetes, ConfigMaps are mounted as symbolic links. Because of this, I cannot easily use the mounting script functionality.

lidel commented 1 month ago

@jesusvico sounds sensible, as long links are resolvable. Mind submitting a PR?

github-actions[bot] commented 1 month ago

Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days.

github-actions[bot] commented 1 month ago

This issue was closed because it is missing author input.