Open Kubuxu opened 8 years ago
@Kubuxu is this still an issue?
Just tired it again, it is still an issue.
I also got following log during ipfs daemon close:
13:49:20.932 ERROR mfs: republishRoot error: context canceled system.go:255
Still an issue. Is there some reason not to fix it?
func (api *NameAPI) Publish(ctx context.Context, p path.Path, opts ...caopts.NamePublishOption) (coreiface.IpnsEntry, error) {
ctx, span := tracing.Span(ctx, "CoreAPI.NameAPI", "Publish", trace.WithAttributes(attribute.String("path", p.String())))
defer span.End()
fmt.Println("--- name.publish got here?", p, opts)
if err := api.checkPublishAllowed(); err != nil {
fmt.Println("--- not allowed!")
return nil, err
}
It's (silently) not getting very far in this function for the same reason that the ipfs name publish
command doesn't work while ipns is mounted (#1186 #964) So either we need to add a new option like AllowWhileMounted to github.com/ipfs/interface-go-ipfs-core/options, or add another argument to this Publish function to allow an override, or break it up into Publish and DoPublish or something like that.