ipfs / kubo

An IPFS implementation in Go
https://docs.ipfs.tech/how-to/command-line-quick-start/
Other
16.03k stars 3k forks source link

ipfs diag cmds failure #4795

Open Kubuxu opened 6 years ago

Kubuxu commented 6 years ago

t0065-active-requests.sh:


expecting success: 
  ipfs diag cmds > cmd_out

ok 8 - command works

expecting success: 
  grep "diag/cmds" cmd_out > /dev/null

ok 9 - invoc shows up in output

expecting success: 
  ipfs log tail &
  LOGPID=$!
  go-sleep 100ms

ok 10 - start longer running command

expecting success: 
  ipfs diag cmds > cmd_out2

ok 11 - long running command shows up

expecting success: 
  grep "log/tail" cmd_out2 | grep "true" > /dev/null

not ok 12 - output looks good
#   
#     grep "log/tail" cmd_out2 | grep "true" > /dev/null
#   

expecting success: 
  kill $LOGPID
  go-sleep 0.5s
  kill $LOGPID

  wait $LOGPID || true

./t0065-active-requests.sh: 4: kill: No such process

ok 13 - kill log cmd

expecting success: 
  ipfs diag cmds > cmd_out3

ok 14 - long running command inactive

expecting success: 
  grep "log/tail" cmd_out3 | grep "false"

not ok 15 - command shows up as inactive
#   
#     grep "log/tail" cmd_out3 | grep "false"
#   

expecting success: 
    kill -0 $IPFS_PID

ok 16 - 'ipfs daemon' is still running

expecting success: 
    test_kill_repeat_10_sec $IPFS_PID

ok 17 - 'ipfs daemon' can be killed
schomatis commented 6 years ago

The kill test, following the failed one, is missing the context canceled error. Could that be an indication that the ipfs diag cmds did not start?