search

ipfs / kubo

An IPFS implementation in Go
https://docs.ipfs.tech/how-to/command-line-quick-start/
Other
16.17k stars 3.02k forks source link

move config package default values to new config/default package #4810

Open preetsinojiya opened 6 years ago

preetsinojiya commented 6 years ago

go-ipfs version: 0.4.14-rc1-5622cc5bb Repo version: 6 System version: amd64/darwin Golang version: go1.10

Type: Code Refactoring

Description: 1) repo/config/bootstrap_peers.go 2) repo/config/init.go 3) repo/config/version.go

These files under package config use a lot of default values which users might want to customize for themselves.

I think a better design would be to move these default values to a new package config/default. So that user has one place to go if they want to tweak something.

I know this is a minor thing but might be useful for users and developers for future maintenance. If you want I can work on this and make a PR.

Stebalien commented 6 years ago

IMO, a better way to do this that's less prone to cause merge conflicts would be to add a custom config profile (see repo/config/profile.go). One can even do this from a separate file with an init function. Does this work for you or do you actually need to override the defaults themselves.

Note: I don't really have any issue with a refactor like this but I can't see a good way to do it that won't end up with an import cycle (default importing config importing default).