search

ipfs / kubo

An IPFS implementation in Go
https://docs.ipfs.tech/how-to/command-line-quick-start/
Other
16.1k stars 3.01k forks source link

Merge 'file ls' and 'ls' commands #5497

Open magik6k opened 6 years ago

magik6k commented 6 years ago

ipfs file ls is this command which duplicates half of the normal ls functionality and missing the other half (plus seems to be a bit outdated).

IMO we should just remove it and merge it's functionality with the normal ls

(first commit which mentions it: https://github.com/ipfs/go-ipfs/commit/434871ba18662db366907e358654728a357f9c0e)

kjzz commented 6 years ago

Hey @magik6k, if you did't finish this work and offical team decide to do this , i am willing to help you do for this. It also will help me learn more about ls and unixfs. Thx a lot.

overbool commented 6 years ago

@magik6k currently, some go-unixfs functions are refactoring: https://github.com/ipfs/go-ipfs/issues/5217 and https://github.com/ipfs/go-unixfs/issues/3.

so, I think this issue could wait until the issues mentioned above are fixed. However, it is also a good choice to solve this issue firstly.

WDYT?

kjzz commented 6 years ago

The reason why i did not fix it immediately is this featuren may cause breanking.Also the issue should influence js-ipfs.So this issue need to be considered carefully by offical team,

overbool commented 6 years ago

@kjzz I don't have any experience with js-ipfs. If this issue will influence js-ipfs, maybe it should be handled with care.

overbool commented 6 years ago

@magik6k In my own view, it's better to fix https://github.com/ipfs/go-ipfs/issues/5502 firstly.