search

ipfs / kubo

An IPFS implementation in Go
https://docs.ipfs.tech/how-to/command-line-quick-start/
Other
16.11k stars 3.01k forks source link

Flaky test: TestHttpApi/Name/TestPublishResolve/nocache/publishPath #8134

Open lidel opened 3 years ago

lidel commented 3 years ago

https://app.circleci.com/pipelines/github/ipfs/go-ipfs/4614/workflows/78e66f96-3a5a-49f7-8b4f-bd7eed6d5f9d/jobs/51200 failed:

FAIL: TestHttpApi/Name/TestPublishResolve/nocache/publishPath (0.65s)

A possible suspect is something racy around IPNS:

=== RUN   TestHttpApi/Name/TestPublishResolve/nocache/publishPath
    TestHttpApi/Name/TestPublishResolve/nocache/publishPath: name.go:95: failed to find any peer in table

After re-running it is green, so filling this issue so we don't forget to fix this (tbd: race or a flaky test).

schomatis commented 2 years ago

Unassinging from this: having trouble reproducing the issue and every testbed run is expensive enough to not run this in the 100s/1000s (even when manually deactivating everything but TestHttpApi/Name/TestPublishResolve/nocache/publishPath). Also, the error seems buried in the libp2p stack I'm not familiar enough with (if someone is able to isolate this more toward a unit test and not this big integration one I might be able to dig deeper if useful).