"ipfs dns" fails on subdomains containing underscores

ipfs / kubo

An IPFS implementation in Go

https://docs.ipfs.tech/how-to/command-line-quick-start/

Other

16.05k stars 3.01k forks source link

"ipfs dns" fails on subdomains containing underscores #8186

Closed SuzanneSoy closed 3 years ago

SuzanneSoy commented 3 years ago

Version information:

go-ipfs version: 0.8.0
Repo version: 11
System version: amd64/linux
Golang version: go1.16.4

Description:

ipfs dns fails on subdomains containing underscores, but the dnslink entry is present and can be fetched using dig:

$ ipfs dns computer_programmer.neocities.org
Error: not a valid domain name: computer_programmer.neocities.org

$ dig +short TXT computer_programmer.neocities.org
"dnslink=/ipfs/QmPfFntYpZcyom5XnQN1st2YvCANykPWYrTrUzTkqpgJFT"

welcome[bot] commented 3 years ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

"Priority" labels will show how urgent this is for the team.
"Status" labels will show if this is ready to be worked on, blocked, or in progress.
"Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

BigLep commented 3 years ago

In 0.9 we made significant changes to our DNS handling and we're no longer coupled to the ICANN list. Please reopen if this manifests on 0.9. Thanks!