ipfs / kubo

An IPFS implementation in Go
https://docs.ipfs.tech/how-to/command-line-quick-start/
Other
16.18k stars 3.02k forks source link

Do not announce non-dialable addresses #9858

Open hacdias opened 1 year ago

hacdias commented 1 year ago

Checklist

Description

Right now, Kubo let's us put addresses in Addresses.Announce that we do not listen on and are, therefore, not dialable. It doesn't really make sense to be able to advertise addresses we do not listen on. This is a potential improvement. Right now I think it can also create some confusion, such as in #9823.

See https://github.com/ipfs/kubo/pull/9857#discussion_r1186080276

cc @aschmahmann

BigLep commented 1 year ago

@hacdias : I put this in 0.22 "Best Effort Track". Let me know if you disagree.

guillaumemichel commented 1 year ago

We also probably don't want local addresses to be advertised globally (for Kademlia see https://github.com/libp2p/go-libp2p-kad-dht/pull/839)