search

ipfs / kubo

An IPFS implementation in Go
https://docs.ipfs.tech/how-to/command-line-quick-start/
Other
16k stars 3k forks source link

secp256k1 key support is missing pem-pkcs8-cleartext import/export #9912

Open lidel opened 1 year ago

lidel commented 1 year ago

Seems https://github.com/ipfs/kubo/pull/9830 was missing a test for --format :)

cc @Jorropo @imthe1

Installation method

built from source

Version

0.20.0-dev

Description


$ ipfs key gen --type=secp256k1 key_secp256k1
$ ipfs key export key_secp256k1 -f pem-pkcs8-cleartext --output key.pem
Error: marshalling key to PKCS8 format: x509: unknown key type while marshaling PKCS#8: *crypto.Secp256k1PrivateKey
Jorropo commented 1 year ago

See I was right, I heard about it !

@imthe-1 could you please take a look else I would have to revert for 0.21 ? Sounds easy to fix and add the missing test :'(

I've grepped for Ed25519 and it seems you also missed this too :slightly_smiling_face: https://github.com/ipfs/kubo/blob/67e1a173fcde1b7c4b09464184aea8ef86bedab2/config/init.go#L202

imthe-1 commented 1 year ago

sure @Jorropo

Jorropo commented 1 year ago

I think it is fine to release rcs with this bug, but if a PR fixing this is not merged when we do the final 0.21 we will revert 67e1a173fcde1b7c4b09464184aea8ef86bedab2. Then PR could be reopenned if anyone want to pick this up.

imthe-1 commented 1 year ago

@Jorropo i am on it now...any rough idea on when we plan to release v0.21?

Jorropo commented 1 year ago

@imthe-1 today but I have blocking issues still open so as long as I'm not finished on that it won't happen. I also have a big 0.21 review queue.

Probably Thursday

TJKoury commented 7 months ago

@imthe-1 Are you still working on this / do you need help with it?

I was using this functionality, updated my install and poof! Need it back and am willing to write code / tests as required.