Open jclab-joseph opened 1 year ago
@marten-seemann since this is logged in DEBUG level, I would assume it's a part of expected operations. Is it safe to ignore? Maybe we could adjust this message to be less confusing?
@lidel oops. Sorry, my explanation was poor. Because of this issue, objects are not shared between the two peers. PINNING on ipfs-cluster fails.
This is where the error occurs: https://github.com/libp2p/go-libp2p/blob/757bf591361cc21b5f7abff4b9afacc7ef58ab30/p2p/net/pnet/psk_conn.go#L31-L37
I believe that when this error occurs, no connection can be established.
@marten-seemann should we consider wrapping the shortErr
in the underlying error in the pnet code in go-libp2p to give more clarity here?
There's no need to wrap it. It's only used at this one place. I wouldn't be opposed to modifying the string representation, but I'm also not sure what would be a better message. "could not read full nonce" is pretty much all we know at that point. Maybe prefix is with "psk:"?
@marten-seemann "could not read full nonce" is a very correct error message but it's unhelpful if you don't already know about the issue what this means. What about "could not read full nonce (does your PNET keys match ?)" ?
That's not what this error is, see linked code above.
Oh so it's the TCP connection being cut short ?
For example. Could be anything that doesn’t allow us to read the full nonce.
Checklist
Installation method
built from source
Version
Config
Description
Bitswap seems to throw the error "accept upgrade error: failed to negotiate security protocol: privnet: could not read full nonce". But the swarm connection works just fine.
swarm.key is the same.
12D3KooWMfT7tYd4Az7iQVz5RFL2voFkZBkf4Z9J2TXnD7MqNijM : Current IPFS Node
12D3KooWHfPzNawb4yt5KmYTLu4nDDgtLvp3eXiUsF9dx2cPNBv8 : Target IPFS Node
Log