Kubo v0.22.0 feedback - Githubissues

galargh commented 1 year ago

Improvements related to https://github.com/ipfs/kubo/issues/9911

galargh commented 1 year ago

https://filecoinproject.slack.com/archives/C04M8232QRW/p1690456755274109?thread_ts=1690375900.878299&cid=C04M8232QRW

Ok thx, I just did go install github.com/ipfs/kuboreleaser/cmd/kuboreleaser@latest would be nice if I could do kuboreleaser env instead

Jorropo commented 1 year ago

I don't like that GPG ask for me a passphrase:

Please provide a GPG passphrase for the key E73D5CF05FC2A3CD0A62C557C5B8248338D8A171.
GPG passphrase:

I guess it's gonna save it somewhere which kinda defeats the point of a passphrase. ~~After reading the source it loads the key, the text could be mentioned to explain how this key is used.~~

It does save it to .env.

Or better when I use git -S a GTK prompt automagically open to ask me for my passphrase when required, would be nice to do the same thing, also this has a "sudo mode" if I enter the password once with a session it does not reask me again in the short while.

Jorropo commented 1 year ago

Would be nice if the chore: update version commit was signed, (idk how it's gonna make the tag, if the tag is signed by me then this is not important).

Jorropo commented 1 year ago

Your release PR is ready at https://github.com/ipfs/kubo/pull/10034\nIf needed, check out the release-v0.22.0 branch of ipfs/kubo repository and cherry-pick commits from master using the following command:

Is someone trying to use \n in an ` string literal ?

Jorropo commented 1 year ago

I would like to have a publish-to-all step that merge all the publish steps (ideally concurrently but fine if not).

galargh commented 1 year ago

https://github.com/ipfs/kubo/issues/9911#issuecomment-1680126190

BigLep commented 9 months ago

@Jorropo @hacdias : is there anything open here to still to handle or can we resolve?

hacdias commented 9 months ago

I don't think any of this has been handled yet

galargh commented 9 months ago

Here's a quick summary:

[x] Prompt for GPG pass instead of saving it to .env - addressed in https://github.com/ipfs/kuboreleaser/pull/23
[x] Sign chore: update version commit - decided not to address it since the subsequent tag is signed by whomever drives the release
[x] \n rendering - addressed in https://github.com/ipfs/kuboreleaser/pull/23
[ ] add publish-to-all command (it should run all the other publish commands)
[ ] make sure marking releases as latest in ipfs/kubo works as expected (tldr, now, if we release a patch for the previous major/minor version, it will be marked as latest even though it should not)
[ ] add env command (it should do what make env does; it will allow installing kuboreleaser through go install without cloning the repo)

hacdias commented 9 months ago

(I guess I have to update my clone 😆 )

hacdias commented 8 months ago

I extracted the next steps to #30 , #31 and #32.

ipfs / kuboreleaser

Kubo v0.22.0 feedback #17